Groups > linux.kernel > #1261951

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Michael Welling <mwelling@ieee.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings
Date	Wed, 04 Nov 2015 00:20:01 +0100
Message-ID	<qqT1T-RQ-5@gated-at.bofh.it> (permalink)
References	<qpswO-4lU-13@gated-at.bofh.it> <qpswO-4lU-17@gated-at.bofh.it> <qqpdv-6XC-5@gated-at.bofh.it> <qqumS-1BG-5@gated-at.bofh.it> <qqEcy-83d-5@gated-at.bofh.it> <qqLQJ-4xa-7@gated-at.bofh.it> <qqM0q-4Hz-23@gated-at.bofh.it> <qqSIy-vE-1@gated-at.bofh.it>
X-Original-To	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=OBlqHlw0NxQ4vHZAXEiYKykKTAAgqqsxRX+RmTjWBks=; b=zhrp9ZBE3TdOxW8u4ayY06NM5ldekAh/pJ5AA2QLNFrUBFu4ViMp8G8nymEw2xvSZa j7SQBHcqrTE4MTrJDX7CgHEBlGoGOWUqJvMxZgKCKFbyYvybWmYZaKnEXPpuhc5LgdZq C7GRKlXcgGQpka26ApEe4q9KmuYHD9L2rrsbHAed4E7QGA1nberEdkcpg8RcCRD1keLw PbVAVdvesk25iTVMZJl0JKG5l9jK00p4A4uLd9fCbXEFZ+f7LVg7pbksUeHs/pCfnqiO z+U0kB9HLdBCqs3Yk5l8gEX+UXhwGRKuTRXiV9g+Ts5tpIVqlzl2cOuaqbSM+0oVQt52 zbdA==
X-Received	by 10.50.36.35 with SMTP id n3mr20544789igj.31.1446592326734; Tue, 03 Nov 2015 15:12:06 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	64
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh@kernel.org>, kbuild test robot <lkp@intel.com>, kbuild-all@01.org, Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>, Felipe Balbi <balbi@ti.com>, Sebastian Reichel <sre@kernel.org>, Roger Quadros <rogerq@ti.com>, Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
X-Original-Date	Tue, 3 Nov 2015 17:11:56 -0600
X-Original-Message-ID	<20151103231156.GA10138@deathstar>
X-Original-References	<1446252086-24334-1-git-send-email-mwelling@ieee.org> <1446252086-24334-5-git-send-email-mwelling@ieee.org> <CAL_JsqKpbrWcHj4eubWMAjtVRHE8TTN_qC5S=J7qzcf8khpzng@mail.gmail.com> <20151102205028.GA2571@deathstar> <20151103072124.GA33601@dtor-ws> <CAL_JsqKb0ms5syf6oTkEw6BGt0nUeqg6=Sm4Zd-5pH9JPrqLiQ@mail.gmail.com> <20151103154117.GA13271@deathstar> <20151103225913.GA29032@dtor-ws>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1261951

Show key headers only | View raw

On Tue, Nov 03, 2015 at 02:59:13PM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 03, 2015 at 09:41:17AM -0600, Michael Welling wrote:
> > On Tue, Nov 03, 2015 at 09:31:10AM -0600, Rob Herring wrote:
> > > On Tue, Nov 3, 2015 at 1:21 AM, Dmitry Torokhov
> > > <dmitry.torokhov@gmail.com> wrote:
> > > > On Mon, Nov 02, 2015 at 02:50:29PM -0600, Michael Welling wrote:
> > > >> On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote:
> > > >> > > +Required properties:
> > > >> > > + - compatible                : "ti,tsc2004"
> > > >> > > + - interrupts                : IRQ specifier
> > > >> > > + - vio-supply                 : Regulator specifier
> > > >> >
> > > >> > reg property?
> > > >>
> > > >> Rob,
> > > >>
> > > >> It appears that I missed this in the description.
> > > >>
> > > >> Probably because I was following the lead of the ts2005 description.
> > > >>
> > > >> How does this look:
> > > >> - reg                 : I2C address. 0x48 - 0x4b based on the voltage applied to
> > > >>                         the AD1 and AD0 inputs on the IC.
> > > >>
> > > >
> > > > How about the version below?
> > > >
> > > > Thanks.
> > > >
> > > > --
> > > > Dmitry
> > > >
> > > >
> > > > Input: tsc2004 - document ts2004 dt bindings
> > 
> > Just noticed that it says ts2004 instead of tsc2004 in the subject.
> > Otherwise, I am fine with it.
> > 
> > Thanks for the assistance.
> > 
> > Still no acks or reviews for the other patches in the series.
> > I would like for someone to test the tsc2005 support to see if it still works.
> > 
> > The tsc2004 works very well on the target that I have here.
> 
> I folded this patch into the patch #3 and applied everything.
>

Great.

Will this patch series conflict with the patch series to take out the .owner=THIS_MODULE
from spi_drivers?

https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1004626.html
 
> Thanks!
> 
> -- 
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Rob Herring <robh@kernel.org> - 2015-11-02 16:30 +0100
  Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Michael Welling <mwelling@ieee.org> - 2015-11-02 22:00 +0100
    Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-03 08:30 +0100
      Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Rob Herring <robh@kernel.org> - 2015-11-03 16:40 +0100
        Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Michael Welling <mwelling@ieee.org> - 2015-11-03 16:50 +0100
          Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-04 00:00 +0100
            Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Michael Welling <mwelling@ieee.org> - 2015-11-04 00:20 +0100
              Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-04 00:40 +0100

csiph-web