Re: [PATCH 2/2] pstore: fix code comment to match code

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] pstore: fix code comment to match code
Date	2015-11-03 21:10 +0100
Message-ID	<qqQ42-7sq-7@gated-at.bofh.it> (permalink)
References	<qpGgq-4vl-23@gated-at.bofh.it> <qpGgq-4vl-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Oct 31, 2015 at 8:23 AM, Geliang Tang <geliangtang@163.com> wrote:
> Fix code comment about kmsg_dump register so it matches the code.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  fs/pstore/platform.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 0aab920..588461b 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -361,6 +361,9 @@ static struct kmsg_dumper pstore_dumper = {
>         .dump = pstore_dump,
>  };
>
> +/*
> + * Register with kmsg_dump to save last part of console log on panic.
> + */
>  static void pstore_register_kmsg(void)
>  {
>         kmsg_dump_register(&pstore_dumper);
> @@ -434,8 +437,6 @@ static int pstore_write_compat(enum pstore_type_id type,
>   * read function right away to populate the file system. If not
>   * then the pstore mount code will call us later to fill out
>   * the file system.
> - *
> - * Register with kmsg_dump to save last part of console log on panic.
>   */
>  int pstore_register(struct pstore_info *psi)
>  {
> --
> 2.4.3
>
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] efi-pstore: fix kernel-doc argument name Geliang Tang <geliangtang@163.com> - 2015-10-31 16:30 +0100
  [PATCH 2/2] pstore: fix code comment to match code Geliang Tang <geliangtang@163.com> - 2015-10-31 16:30 +0100
    Re: [PATCH 2/2] pstore: fix code comment to match code Kees Cook <keescook@chromium.org> - 2015-11-03 21:10 +0100
  Re: [PATCH 1/2] efi-pstore: fix kernel-doc argument name Kees Cook <keescook@chromium.org> - 2015-11-03 21:10 +0100

csiph-web