Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC

From	Saurabh Sengar <saurabh.truth@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC
Date	2015-11-03 18:40 +0100
Message-ID	<qqNIS-5QT-11@gated-at.bofh.it> (permalink)
References	<qqMMO-5fY-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>It's slightly winding code, but if you look at the callers of
>efivar_init() you'll see that none of them set both 'atomic' and
>'duplicates', so dup_variable_bug() will never be called while holding
>a spinlock.

>Or am I missing something?

I was assuming that there could be a possibility when both 'atomic' and 'duplicates' are set.
If both can never be set, then this patch does not make any sense, you are correct.
Thank you for review
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] efi: replace GFP_KERNEL with GFP_ATOMIC Matt Fleming <matt@codeblueprint.co.uk> - 2015-11-03 17:40 +0100
  Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-03 18:40 +0100

csiph-web