Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261495

Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts

Show all headers | View raw

Ming Lei <tom.leiming@gmail.com> writes:

>>> The above should be 'else if', otherwise the current queue will be set
>>> twice.
>>
>> I moved the list add below this to avoid that very issue.  See:
>>
>>>> +               queue_set_hctx_shared(q, true);
>>>>         list_add_tail(&q->tag_set_list, &set->tag_list);
>>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> This seemed the cleanest way to structure the code to avoid the double
>> walking of the hctx list for the current q.
>
> OK, it is correct, then v1 is fine.
>
> Reviewed-by: Ming Lei <ming.lei@canonical.com>

Thanks, Ming.  Jens, I'll re-send with the list_is_singular change and
this one should be ready for merging.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts Ming Lei <tom.leiming@gmail.com> - 2015-11-01 01:40 +0100
  Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts Jeff Moyer <jmoyer@redhat.com> - 2015-11-02 15:10 +0100
    Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts Ming Lei <tom.leiming@gmail.com> - 2015-11-03 02:20 +0100
      Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts Jeff Moyer <jmoyer@redhat.com> - 2015-11-03 14:30 +0100
        Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun  counts Jens Axboe <axboe@kernel.dk> - 2015-11-03 16:30 +0100

csiph-web