Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

From	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Newsgroups	linux.kernel
Subject	Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)
Date	2015-11-03 12:30 +0100
Message-ID	<qqHWN-23s-1@gated-at.bofh.it> (permalink)
References	<qqpdv-6XC-3@gated-at.bofh.it> <qquZB-250-23@gated-at.bofh.it> <qqxNM-3Pp-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em 02-11-2015 22:38, Cong Wang escreveu:
> On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang <cwang@twopensource.com> wrote:
>>
>> Good catch!
>>
>> This is probably introduced by:
>>
>> commit baf606d9c9b12517e47e0d1370e8aa9f7323f210
>> Author: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>> Date:   Wed Mar 18 14:50:42 2015 -0300
>>
>>      ipv4,ipv6: grab rtnl before locking the socket

Yes, that commit introduced this inverse order situation by not fixing 
the get path of it.

>> I am thinking what is the right way to fix it...
>
> Please try the attached patch.
>
> Thanks!

Patch LGTM, same design and covered all rtnl_lock()s I could find on get 
path now. Thanks!

   Marcelo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400) Sasha Levin <sasha.levin@oracle.com> - 2015-11-02 16:30 +0100
  Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400) Cong Wang <cwang@twopensource.com> - 2015-11-02 22:40 +0100
    Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400) Cong Wang <cwang@twopensource.com> - 2015-11-03 01:40 +0100
      Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400) Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2015-11-03 12:30 +0100

csiph-web