Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261232

Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring driver

Show all headers | View raw

Hi Guenter,

On 11/2/2015 11:27 PM, Guenter Roeck wrote:
> On 11/01/2015 09:24 PM, Milo Kim wrote:
>> LM3633 and LM3697 are TI LMU MFD device.
>> Those device have hardware monitoring feature which detects opened or
>> shorted circuit case.
>>
> Sure, but it only makes sense if you provide standard hwmon attributes
> which can be interpreted by the "sensors" command. Which is not the case
> here. You neither have a standard device type (light is not handled by hwmon),
> nor standard attributes, nor do the attributes return standard values.
>
> I think there may be a basic misunderstanding. hwmon is not intended
> to monitor a specific chip on the board. Its scope is to monitor the
> system (such as temperature, voltages, or current).
>
> In your case, it might be better to attach the attributes to the mfd device.
>

OK, got your point. Thanks a lot for your suggestion.

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring driver Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
  Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring  driver Guenter Roeck <linux@roeck-us.net> - 2015-11-02 15:30 +0100
    Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring  driver "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:10 +0100

csiph-web