Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1261211
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: MMC/regulator boot hang in -next |
| Date | 2015-11-03 06:50 +0100 |
| Message-ID | <qqCDM-6X8-21@gated-at.bofh.it> (permalink) |
| References | <qqtqO-10k-15@gated-at.bofh.it> <qqudc-1yk-15@gated-at.bofh.it> <qqvsC-2u9-15@gated-at.bofh.it> <qqwf0-2M7-13@gated-at.bofh.it> <qqwoG-34I-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Nov 02, 2015 at 03:04:29PM -0800, John Stultz wrote:
> On Mon, Nov 2, 2015 at 2:58 PM, Mark Brown <broonie@kernel.org> wrote:
> > No, the internal get voltage call shouldn't be locking in the first
> > place (and indeed it doesn't do so AFAICT?).
> } else if (rdev->supply) {
> ret = regulator_get_voltage(rdev->supply); <-----
> } else {
> Where _regulator_get_voltage() is called from
> regulator_set_voltage_unlocked(), called from regulator_set_voltage().
>
Well, that's the issue then - get_voltage() needs to be locking the
supplies like set_voltage() does.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
MMC/regulator boot hang in -next John Stultz <john.stultz@linaro.org> - 2015-11-02 21:00 +0100
Re: MMC/regulator boot hang in -next Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-11-02 21:50 +0100
Re: MMC/regulator boot hang in -next John Stultz <john.stultz@linaro.org> - 2015-11-02 22:00 +0100
Re: MMC/regulator boot hang in -next John Stultz <john.stultz@linaro.org> - 2015-11-02 23:10 +0100
Re: MMC/regulator boot hang in -next John Stultz <john.stultz@linaro.org> - 2015-11-02 23:30 +0100
Re: MMC/regulator boot hang in -next Mark Brown <broonie@kernel.org> - 2015-11-03 00:00 +0100
Re: MMC/regulator boot hang in -next John Stultz <john.stultz@linaro.org> - 2015-11-03 00:10 +0100
Re: MMC/regulator boot hang in -next Mark Brown <broonie@kernel.org> - 2015-11-03 06:50 +0100
Re: MMC/regulator boot hang in -next Mark Brown <broonie@kernel.org> - 2015-11-02 22:20 +0100
csiph-web