Re: [v7, 2/6] fsl/fman: Add FMan support

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [v7, 2/6] fsl/fman: Add FMan support
Date	2015-11-03 05:20 +0100
Message-ID	<qqBeG-69S-13@gated-at.bofh.it> (permalink)
References	<qqBeG-69S-15@gated-at.bofh.it> <qqBeG-69S-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: <igal.liberman@freescale.com>
Date: Mon, 2 Nov 2015 14:30:12 +0200

> +static int clear_iram(struct fman *fman)
> +{
> +	struct fman_iram_regs __iomem *iram;
> +	int i, count;
> +
> +	iram = (struct fman_iram_regs __iomem *)(fman->base_addr + IMEM_OFFSET);

"fman->base_addr" is of type "void __iomem *", therefore no cast should
be necessary at all.

Please audit your entire driver submission for this problem.

THanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [v7, 2/6] fsl/fman: Add FMan support David Miller <davem@davemloft.net> - 2015-11-03 05:20 +0100

csiph-web