Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260247

Re: [PATCH] net: smsc911x: Reset PHY during initialization

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: smsc911x: Reset PHY during initialization
Date 2015-11-01 23:00 +0100
Message-ID <qq8Pn-5dJ-9@gated-at.bofh.it> (permalink)
References <qpbZ0-2NI-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Pavel Fedin <p.fedin@samsung.com>
Date: Fri, 30 Oct 2015 10:06:19 +0300

> On certain hardware after software reboot the chip may get stuck and fail
> to reinitialize during reset. This can be fixed by ensuring that PHY is
> reset too.
> 
> Old PHY resetting method required operational MDIO interface, therefore
> the chip should have been already set up. In order to be able to function
> during probe, it is changed to use PMT_CTRL register.
> 
> The problem could be observed on SMDK5410 board.
> 
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>

I'm pretty sure this is going to break the PHY loopback test.

This is such a tricky and fragile area to get right, therefore I
want you to specifically guard any change in how PHY reset is
done with tests against the specific chips that have the problem.

Furthermore, I want you to test whether this has any negative
effects on the PHY loopback test.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: smsc911x: Reset PHY during initialization Pavel Fedin <p.fedin@samsung.com> - 2015-10-30 08:10 +0100
  Re: [PATCH] net: smsc911x: Reset PHY during initialization David Miller <davem@davemloft.net> - 2015-11-01 23:00 +0100
    RE: [PATCH] net: smsc911x: Reset PHY during initialization Pavel Fedin <p.fedin@samsung.com> - 2015-11-02 08:20 +0100

csiph-web