Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260163

Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

Show all headers | View raw

Hi,

On 30/10/15 09:28, Arnd Bergmann wrote:
> On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote:
>> +               of_property_read_string_index(node, "clock-output-names",
>> +                                             i, &clk_name);
>> +
>> +               if (index == 17 || (index >= 29 && index <= 31))
>> +                       clk_parent = AHB2;
>> +               else if (index <= 63 || index >= 128)
>> +                       clk_parent = AHB1;
>> +               else if (index >= 64 && index <= 95)
>> +                       clk_parent = APB1;
>> +               else if (index >= 96 && index <= 127)
>> +                       clk_parent = APB2;
>> +
>> +               clk_reg = reg + 4 * (index / 32);
>>
> 
> Same as for the reset driver, this probably means you should have one
> cell to indicate which bus it is for, and another cell for the
> index.
> 

This is what Maxime suggested in an earlier version:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344213.html

In between I had another version with the parents in DT, but he
didn't like that too.

Jens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/6] clk: sunxi: Add H3 clocks support Jens Kuske <jenskuske@gmail.com> - 2015-10-27 18:00 +0100
  Re: [linux-sunxi] [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Julian Calaby <julian.calaby@gmail.com> - 2015-10-28 00:20 +0100
    Re: [linux-sunxi] [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-04 17:30 +0100
      Re: [linux-sunxi] [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Julian Calaby <julian.calaby@gmail.com> - 2015-11-04 23:20 +0100
  Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Arnd Bergmann <arnd@arndb.de> - 2015-10-30 09:30 +0100
    Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Jens Kuske <jenskuske@gmail.com> - 2015-11-01 14:50 +0100
    Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-04 17:30 +0100

csiph-web