[PATCH urgent 2/2] x86/vm86: Set thread.vm86 to NULL on fork/clone

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Lutomirski <luto@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH urgent 2/2] x86/vm86: Set thread.vm86 to NULL on fork/clone
Date	Sat, 31 Oct 2015 06:50:01 +0100
Message-ID	<qpxd7-7ms-3@gated-at.bofh.it> (permalink)
References	<qpxd7-7ms-5@gated-at.bofh.it>
X-Original-To	x86@kernel.org, linux-kernel@vger.kernel.org
X-Mailer	git-send-email 2.4.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	Brian Gerst <brgerst@gmail.com>, Linus Torvalds <torvalds@linux-foundation.org>, Borislav Petkov <bp@alien8.de>, Stas Sergeev <stsp@list.ru>, Andy Lutomirski <luto@kernel.org>
X-Original-Date	Fri, 30 Oct 2015 22:42:46 -0700
X-Original-Message-ID	<71c5d6985d70ec8197c8d72f003823c81b7dcf99.1446270067.git.luto@kernel.org>
X-Original-References	<cover.1446270067.git.luto@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1259938

Show key headers only | View raw

thread.vm86 points to per-task information -- the pointer should not
be copied on clone.

Fixes: d4ce0f26c790 ("x86/vm86: Move fields from 'struct kernel_vm86_struct' to 'struct vm86'")
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 arch/x86/kernel/process.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 2199d9b774c8..b9ac5434e176 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -83,6 +83,9 @@ EXPORT_SYMBOL_GPL(idle_notifier_unregister);
 int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
 {
 	memcpy(dst, src, arch_task_struct_size);
+#ifdef CONFIG_VM86
+	dst->thread.vm86 = NULL;
+#endif
 
 	return fpu__copy(&dst->thread.fpu, &src->thread.fpu);
 }
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH urgent 2/2] x86/vm86: Set thread.vm86 to NULL on fork/clone Andy Lutomirski <luto@kernel.org> - 2015-10-31 06:50 +0100
  [tip:x86/urgent] x86/vm86: Set thread.vm86 to NULL on fork/clone tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2015-10-31 10:00 +0100

csiph-web