Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible

From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible
Date	2015-10-31 01:30 +0100
Message-ID	<qpsds-4eY-11@gated-at.bofh.it> (permalink)
References	<qcqMa-4Jw-5@gated-at.bofh.it> <qp8Rr-H0-3@gated-at.bofh.it> <qpfpU-4J3-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Daniel,

Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano:
> On 10/30/2015 04:43 AM, Caesar Wang wrote:
> > Hi Daniel,
> >
> > 在 2015年10月01日 03:14, Heiko Stübner 写道:
> >> Hi Daniel,
> >>
> >> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano:
> >>> On 09/25/2015 04:14 AM, Caesar Wang wrote:
> >>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
> >>>> There are some failure with build up on timer driver for rockchip.
> >>>>
> >>>> Says:
> >>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at  operand
> >>>> 1 --
> >>>> `dsb`
> >>>> ...
> >>>>
> >>>> The problem was different semantics of dsb on btw arm32 and arm64,
> >>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" param
> >>>> is the default which you are allow to omit, so on arm32 dsb()and
> >>>> dsb(sy)
> >>>> are the same.
> >>>>
> >>>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> >>> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> >> as you have "just" Acked these patches, I guess you are expecting them
> >> to go
> >> through the same tree as the devicetree changes, right?
> >
> > I'm wonder if someone will apply this series patchs but the wait.:-)
> > In fact, I'm no sure that the Acked is really meaning.:-
> 
> Yes, by acking the patch I say I am ok with it and I agree it can go 
> through another tree.

although I guess the two clocksource changes could very well just go
through your tree. dsb() -> dsb(sy) is supposed to be equal and the second
one is just cosmetics.  The Kconfig and dts changes need to wait in any case
for 4.5 ... but I guess that may be true for the clocksource changes as well?


Heiko

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-10-30 04:50 +0100
  Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-30 11:50 +0100
    Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible Heiko Stuebner <heiko@sntech.de> - 2015-10-31 01:30 +0100
      Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-31 14:10 +0100
      Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 18:30 +0100
        Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-11-03 03:10 +0100
          Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 09:40 +0100
            Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more  compatible Caesar Wang <caesar.upstream@gmail.com> - 2015-11-03 11:10 +0100

csiph-web