Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259512

Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

Show all headers | View raw

Hi,

Am Freitag, 30. Oktober 2015, 16:22:49 schrieb Zain Wang:
> Add DT bindings documentation for the rk3288 crypto drivers.
> 
> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
> ---
>  .../devicetree/bindings/crypto/rk-crypto.txt       | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/rk-crypto.txt
> 
> diff --git a/Documentation/devicetree/bindings/crypto/rk-crypto.txt b/Documentation/devicetree/bindings/crypto/rk-crypto.txt
> new file mode 100644
> index 0000000..1e50768
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rk-crypto.txt
> @@ -0,0 +1,31 @@
> +Rockchip Electronics And Security Accelerator
> +
> +Required properties:
> +- compatible: should be "rockchip,crypto"
> +- reg: base physical address of the engine and length of memory mapped
> +       region.
> +- interrupts: interrupt number
> +- clocks: clock specifiers
> +- clock-names: "aclk_crypto" used to clock data
> +			   "hclk_crypto" used to clock data
> +			   "srst_crypto" used to clock crypto accelerator
> +			   "apb_pclk"    used to clock dma

The TRM area of the crypto IP block does not specifiy any special naming for
its clocks, but as a general rule clock names are in the scope of the ip block
so there is no need to add _crypto to every one of them :-) .

I'd suggest clock-names as "aclk", "hclk", "crypto" for the devicetree, with
crypto being the clock that actually drives the operation.


Secondly, why do you need to drive the clock of the peripheral dma-
controller itself (your apb_pclk)? The documentation in the TRM is
quite sparse, so this might very well be justified, but it looks odd that
you need to control the dmac1-clock when it looks like the crypto block
is doing its own dma and neither system-dma has any crypto-related
channel.

So I'd really like some explanation for this :-)


Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation Zain Wang <zain.wang@rock-chips.com> - 2015-10-30 09:30 +0100
  Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings  documentation Mark Rutland <mark.rutland@arm.com> - 2015-10-30 15:10 +0100
    Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings  documentation Zain <zain.wang@rock-chips.com> - 2015-11-02 10:20 +0100
      Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation Rob Herring <robh+dt@kernel.org> - 2015-11-02 16:50 +0100
        Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings  documentation Zain <zain.wang@rock-chips.com> - 2015-11-03 01:30 +0100
  Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation Heiko Stuebner <heiko@sntech.de> - 2015-10-30 15:10 +0100

csiph-web