Re: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM
Date	2015-10-30 15:00 +0100
Message-ID	<qpinN-6tx-13@gated-at.bofh.it> (permalink)
References	<qnXv5-4Vx-35@gated-at.bofh.it> <qpetQ-48J-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2015-10-30 at 10:40 +0100, Borislav Petkov wrote:
> On Mon, Oct 26, 2015 at 03:22:24PM -0600, Toshi Kani wrote:
> > @@ -545,10 +545,15 @@ static int einj_error_inject(u32 type, u32 flags, u64
> > param1, u64 param2,
> >  	/*
> >  	 * Disallow crazy address masks that give BIOS leeway to pick
> >  	 * injection address almost anywhere. Insist on page or
> > -	 * better granularity and that target address is normal RAM.
> > +	 * better granularity and that target address is normal RAM or
> > +	 * NVDIMM.
> >  	 */
> > -	pfn = PFN_DOWN(param1 & param2);
> > -	if (!page_is_ram(pfn) || ((param2 & PAGE_MASK) != PAGE_MASK))
> > +	base_addr = param1 & param2;
> > +	size = (~param2) + 1;
> 
> Hmm, I missed this last time: why are the brackets there?
> 
> AFAIK, bitwise NOT has a higher precedence than addition.

Yes, the brackets are not necessary.  I put them as self-explanatory of the
precedence.  Shall I remove them, and send you an updated patch?

Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 22:30 +0100
  RE: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM "Luck, Tony" <tony.luck@intel.com> - 2015-10-26 23:00 +0100
  Re: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM Borislav Petkov <bp@alien8.de> - 2015-10-30 10:50 +0100
    Re: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-30 15:00 +0100
      Re: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM Borislav Petkov <bp@alien8.de> - 2015-10-30 15:50 +0100

csiph-web