Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM
Date	2015-10-30 14:40 +0100
Message-ID	<qpi4r-6mR-21@gated-at.bofh.it> (permalink)
References	<qp4Xv-6IO-13@gated-at.bofh.it> <qp5Ae-7bw-1@gated-at.bofh.it> <qpg2C-5bX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 30, 2015 at 1:26 PM, Sowmini Varadhan
<sowmini.varadhan@oracle.com> wrote:
> On (10/30/15 02:14), Andy Shevchenko wrote:
>>
>> Does the following has no stubs?
>>
>> > +       struct i40e_pf *pf = hw->back;
>> > +       struct device_node *dp = pci_device_to_OF_node(pf->pdev);
>> > +       const unsigned char *addr;
>> > +
>> > +       addr = of_get_mac_address(dp);
>>
>> ^^^
>
> I was not able to find any.
> I'm fixing up the rest and respinning V2 as a separate thread.

of_net.h contains the stub of of_get_mac_addr() which means you don't
need to put ugly ifdefs in the function.

Have no idea about CONFIG_SPARC though.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 00:40 +0100
  Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-30 01:20 +0100
    Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 12:30 +0100
      Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-30 14:40 +0100

csiph-web