Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1259401

Re: [net-next PATCH] RDS: convert bind hash table to re-sizable hashtable

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [net-next PATCH] RDS: convert bind hash table to re-sizable hashtable
Date 2015-10-30 12:20 +0100
Message-ID <qpfSW-58P-7@gated-at.bofh.it> (permalink)
References <qoHRg-lq-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Wed, 28 Oct 2015 15:51:12 -0700

> +					    &rs->rs_bound_node, ht_parms)) {
>  			*port = rs->rs_bound_port;
>  			ret = 0;
>  			rdsdebug("rs %p binding to %pI4:%d\n",
>  			  rs, &addr, (int)ntohs(*port));
>  			break;
>  		} else {
> -			rds_sock_put(rrs);
> +			rds_sock_put(rs);
> +			ret = -ENOMEM;
> +			break;
>  		}
> +
>  	} while (rover++ != last);
>  
>  	return ret;

This final insert of an empty line is both inappropriate and even
if it was it would not be related to this change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[net-next PATCH] RDS: convert bind hash table to re-sizable hashtable Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2015-10-29 00:00 +0100
  Re: [net-next PATCH] RDS: convert bind hash table to re-sizable  hashtable David Miller <davem@davemloft.net> - 2015-10-30 12:20 +0100
    Re: [net-next PATCH] RDS: convert bind hash table to re-sizable  hashtable santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-30 17:00 +0100

csiph-web