Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259339

Re: [PATCH -next] sparc: Populate 'device' for platform device devicetree nodes

Show all headers | View raw

From: Guenter Roeck <linux@roeck-us.net>
Date: Sun, 25 Oct 2015 17:26:38 -0700

> Since commit 61e82530d80f ("of/platform: Point to struct device from device
> node"), the 'device' pointer in devicetree nodes for platform devices must
> be set for of_find_device_by_node to succeed. This is not the case unless
> the platform device was created using of_platform_device_create(), which
> is not always the case. This causes all sparc images to crash with "Unable
> to handle NULL pointer reference" in functions such as iommu_init(), which
> don't expect of_find_device_by_node() to return NULL.
> 
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> This patch depends on the patch causing the problem (which can not be easily
> reverted). It should probably go through the same tree as that patch,
> or the patches should be merged.

Indeed, please merge this into the tree that added the change in
question:

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] sparc: Populate 'device' for platform device devicetree nodes Guenter Roeck <linux@roeck-us.net> - 2015-10-26 01:30 +0100
  Re: [PATCH -next] sparc: Populate 'device' for platform device  devicetree nodes David Miller <davem@davemloft.net> - 2015-10-30 10:20 +0100

csiph-web