Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259324

[PATCH 1/3] recordmcount: fix endianness handling bug for nop_mcount

Show all headers | View raw

In nop_mcount, shdr->sh_offset and welp->r_offset should handle
endianness properly, otherwise it will trigger Segmentation fault
if the recordmcount main and file.o have different endianness.

Cc: <stable@vger.kernel.org> # 3.0+
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
 scripts/recordmcount.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 49b582a..dda9dba 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -376,8 +376,9 @@ static void nop_mcount(Elf_Shdr const *const relhdr,
 			mcountsym = get_mcountsym(sym0, relp, str0);
 
 		if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
-			if (make_nop)
-				ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset);
+			if (make_nop) {
+				ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
+			}
 			if (warn_on_notrace_sect && !once) {
 				printf("Section %s has mcount callers being ignored\n",
 				       txtname);
-- 
1.7.12.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] recordmcount: bugfix and amend Li Bin <huawei.libin@huawei.com> - 2015-10-30 09:40 +0100
  [PATCH 1/3] recordmcount: fix endianness handling bug for nop_mcount Li Bin <huawei.libin@huawei.com> - 2015-10-30 09:40 +0100
    Re: [PATCH 1/3] recordmcount: fix endianness handling bug for  nop_mcount libin <huawei.libin@huawei.com> - 2015-10-30 09:50 +0100
    Re: [PATCH 1/3] recordmcount: fix endianness handling bug for  nop_mcount Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-30 15:40 +0100
      Re: [PATCH 1/3] recordmcount: fix endianness handling bug for  nop_mcount libin <huawei.libin@huawei.com> - 2015-10-31 03:10 +0100

csiph-web