Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259332

Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should match open parentheses

Show all headers | View raw

On 10/30/2015, Sudip Mukherjee wrote:
>On Thu, Oct 29, 2015 at 09:15:01PM +0100, Bogicevic Sasa wrote:
>> This fixes all errors about alignment with open parentheses as well as
>> one spacing needed around "-" sign since the patch would not be valid if
>> I left it there
>
>1) That becomes two different type of change.
>2) This has already been done by
>a4785ef81023 ("staging: gdm724x: properly indent to match open paranthesis")
>I think you need to refresh your tree against current staging tree.
>
>3) your patch subject says 2/2, the next patch says 3/3 and the one
>after that is saying 4/4. There is something wrong in the way you are
>generating the patches. This 2/2 or 3/3 should not be here unless you
>are sending a series of patch.
>
>regards
>sudip
Ok 1) When I changed the alignment in one of the lines then
checkpatch.pl starts complaining about the spaces in the same line so
what do you do in that situation a) just submit anyway or b) fix it
I guess a according to your email
2) I'll see what the hell did I do to not notice this
3) I just pull, make a change, commit and do git format-patch
master..somebranch. Do I need to create separate branches for all
issues?
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] drivers:staging:gdm724x Fill all alignment should match open parentheses Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-29 21:30 +0100
  Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-30 08:40 +0100
    Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-30 10:00 +0100
      Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-30 10:40 +0100
        Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-30 12:50 +0100
          Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-30 13:00 +0100
            Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-30 13:10 +0100
              Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should  match open parentheses Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-30 13:20 +0100

csiph-web