Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259271

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

Show all headers | View raw

On 30.10.2015 15:58, Pavel Fedin wrote:
>  Hello!
> 
>>> Add documentation for new subnode properties, allowing bank configuration.
>>> Based on u-boot implementation, but heavily reworked.
>>
>> Please, carefully look at:
>> Documentation/devicetree/bindings/net/gpmc-eth.txt
>> Documentation/devicetree/bindings/bus/ti-gpmc.txt
> 
>  Thank you very much. Indeed, this looks very similar. By the way, should i document smsc over sromc in the same manner, writing
> devicetree/bindings/net/sromc-eth.txt?
> 
>  This is a short reply for now, i'll make longer one (or just a new version) after studying these existing bindings and trying to
> apply them.

Existing SROMC bindings document is small so one document for everything
should be sufficient. This can be always split if new type of devices
will be using SROMC (BTW, do you know of any other devices using SROMC
on Exynos?).

> 
>  Pankaj:
> 
>>> +&sromc {
>>> +       pinctrl-names = "default";
>>> +       pinctrl-0 = <&srom_ctl>, <&srom_ebi>;
>>> +
>>> +       ethernet@07000000 {
>>> +               compatible = "smsc,lan9115";
>>> +               reg = <0x07000000 0x10000>;
>>> +               phy-mode = "mii";
>>> +               interrupt-parent = <&gpx0>;
>>> +               interrupts = <5 8>;
>>> +               reg-io-width = <2>;
>>> +               smsc,irq-push-pull;
>>> +               smsc,force-internal-phy;
>>> +
>>> +               samsung,srom-bank = <3>;
>>> +               samsung,srom-data-width = <2>;
>>> +               samsung,srom-timing = <1 9 12 1 9 1 1>;
>>
>> I think this is not correct. We can't change binding of "smsc,lan9115"
>> which is already documented here [1]. These samsung specific srom
>> properties should be in srom node or its subnode, but not in this way.
> 
>  So, if you look at gpmc-eth.txt, you'll see that this approach is perfectly valid (this is a reply to another msg, just don't want
> to post one more single-line reply).


Yes, the binding of smsc,lan9115 is not changed.

Putting srom properties in separate bank node would be good also but
then some mapping (connection) between ethernet and bank should be added
probably...

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet  support for SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-10-29 13:50 +0100
  [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin <p.fedin@samsung.com> - 2015-10-29 13:50 +0100
    Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc  configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-30 07:40 +0100
      RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc  configuration Pavel Fedin <p.fedin@samsung.com> - 2015-10-30 08:00 +0100
        Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc  configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-30 08:30 +0100
          Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration Rob Herring <robh+dt@kernel.org> - 2015-10-30 18:20 +0100
      RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc  configuration Pavel Fedin <p.fedin@samsung.com> - 2015-10-30 11:50 +0100
  [PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-10-29 13:50 +0100
    Re: [PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-10-29 18:50 +0100
  Re: [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and  Ethernet support for SMDK5410 Pankaj Dubey <dubepankaj1980@gmail.com> - 2015-10-29 18:50 +0100
    RE: [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and  Ethernet support for SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-10-30 07:50 +0100

csiph-web