Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260077

Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory

Show all headers | View raw

On 10/31/2015 08:53 PM, Jessica Yu wrote:
> +++ Chris J Arges [30/10/15 22:44 -0500]:
>> The following directory structure will allow for cases when the same
>> function name exists in a single object.
>>     /sys/kernel/livepatch/<patch>/<object>/<function@address>
> 
> Hi Chris, thanks for the patch.
> 
> I think the last time this issue was discussed, the conclusion was
> that concatenating the address to the function name constitutes as an
> information leak (as the sysfs entry is visible to non-root users).
> 
> One option suggested by Josh in that thread would be to do something
> like "func.n", where n is just the nth occurrence of the symbol name.
> Another option might be to keep the func@addr format but not make these
> entries visible to non-root users.
> 
> Jessica
> 

Jessica,

Makes sense to me. Is there a reason why the sysfs entries are visible
to non-root users?

Otherwise, if there is a use-case for keeping the permissions the same,
then I'd be happy to to use the 'func.n' format for v2.

--chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] livepatch: old_name@old_addr scheme in livepatch sysfs directory Chris J Arges <chris.j.arges@canonical.com> - 2015-10-31 04:50 +0100
  Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory Jessica Yu <jeyu@redhat.com> - 2015-11-01 03:00 +0100
    Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory Chris J Arges <chris.j.arges@canonical.com> - 2015-11-01 05:10 +0100
      Re: livepatch: old_name@old_addr scheme in livepatch sysfs  directory Jiri Kosina <jikos@kernel.org> - 2015-11-01 10:10 +0100
        Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory Jessica Yu <jeyu@redhat.com> - 2015-11-02 10:10 +0100

csiph-web