Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260074

Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data

Show all headers | View raw

On Sat, Oct 31, 2015 at 04:26:32PM +0100, Marek Vasut wrote:
> On Saturday, October 31, 2015 at 04:33:28 AM, Brian Norris wrote:
> > -	mtd_device_parse_register(info->cmtd, part_probe_types, &ppdata,
> > +	mtd_device_parse_register(info->cmtd, part_probe_types, NULL,
> 
> Did you miss this one ?

What about it? I removed the parser data (the third argument), but I
can't yet drop the 2nd argument, since those parser types are
different than the defaults. So I can't drop any more arguments, nor can
I convert this to mtd_device_register().

(Now, I'd like to improve the device tree handling of parser types, so
we don't need any more specialized handling in drivers like this.)

> >  			NULL, 0);
> >  	of_free_probes(part_probe_types);
> > 
> 
> 
> This is really good, I like to see the ppdata nonsense finally going away.
> 
> Reviewed-by: Marek Vasut <marex@denx.de>

Thanks for the review! I'm happy to kill off much of this nonsense too.
And I think this will help in the long run on some other things too,
since now we have a canonical place to put common MTD bindings.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 09/11] mtd: drop unnecessary partition parser data Brian Norris <computersforpeace@gmail.com> - 2015-10-31 04:40 +0100
  Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data Marek Vasut <marex@denx.de> - 2015-10-31 16:30 +0100
    Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data Brian Norris <computersforpeace@gmail.com> - 2015-11-01 01:20 +0100
  Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-05 10:00 +0100
    Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data Brian Norris <computersforpeace@gmail.com> - 2015-11-12 00:50 +0100

csiph-web