Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260019

Re: [RFC/PATCH 5/5] perf report: Fix segfault on -g fractral with --stdio

Show all headers | View raw

On Sat, Oct 31, 2015 at 02:15:38AM +0900, Namhyung Kim wrote:

SNIP

>  
>  		if (!rem_sq_bracket)
>  			return ret;
>  
> +		if (callchain_param.value == CCVAL_COUNT) {
> +			rem_node.count = child->parent->children_count - cumul_count;
> +			if (rem_node.count <= 0)
> +				return ret;
> +		}
> +
>  		new_depth_mask &= ~(1 << (depth - 1));
> -		ret += ipchain__fprintf_graph(fp, NULL, &rem_hits, depth,
> +		ret += ipchain__fprintf_graph(fp, &rem_node, &rem_hits, depth,
>  					      new_depth_mask, 0, total_samples,
>  					      left_margin);

this looks like being introduced within your patchset in patch:
  perf callchain: Abstract callchain print function

shouldn't it get fixed in there?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC/PATCH 5/5] perf report: Fix segfault on -g fractral with --stdio Namhyung Kim <namhyung@kernel.org> - 2015-10-30 18:20 +0100
  Re: [RFC/PATCH 5/5] perf report: Fix segfault on -g fractral with  --stdio Jiri Olsa <jolsa@redhat.com> - 2015-10-31 17:20 +0100
    Re: [RFC/PATCH 5/5] perf report: Fix segfault on -g fractral with  --stdio Namhyung Kim <namhyung@kernel.org> - 2015-11-02 07:50 +0100

csiph-web