Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259965

Re: [PATCH v3 2/3] iio: light: lm3533-als: Print error message on invalid resistance

Show all headers | View raw

On 30/10/15 23:50, Bjorn Andersson wrote:
> Print an error message to indicate that invalid configuration data was
> provided in the platform_data, rather than just aborting initialization.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Seems sensible to me.

Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> 
> This patch can be picked independently of the other 2, but included in the
> series for "completeness".
> 
> No changes since v1 in this patch.
> 
>  drivers/iio/light/lm3533-als.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index 076bc46fad03..e56937c40a18 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val)
>  {
>  	int ret;
>  
> -	if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX)
> +	if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) {
> +		dev_err(&als->pdev->dev, "invalid resistor value\n");
>  		return -EINVAL;
> +	};
>  
>  	ret = lm3533_write(als->lm3533, LM3533_REG_ALS_RESISTOR_SELECT, val);
>  	if (ret) {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] devicetree: mfd: Add binding for the TI LM3533 Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-31 01:00 +0100
  [PATCH v3 2/3] iio: light: lm3533-als: Print error message on invalid resistance Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-31 01:00 +0100
    Re: [PATCH v3 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Jonathan Cameron <jic23@kernel.org> - 2015-10-31 11:10 +0100
  [PATCH v3 3/3] mfd: lm3533: Support initialization from Device Tree Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-31 01:00 +0100
  Re: [PATCH v3 1/3] devicetree: mfd: Add binding for the TI LM3533 Jonathan Cameron <jic23@kernel.org> - 2015-10-31 11:10 +0100
  Re: [PATCH v3 1/3] devicetree: mfd: Add binding for the TI LM3533 Rob Herring <robh@kernel.org> - 2015-11-06 03:30 +0100

csiph-web