[PATCH v3 2/3] serial: 8250_early: confirm empty transmitter after sending characters

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 2/3] serial: 8250_early: confirm empty transmitter after sending characters
Date	2015-10-30 03:40 +0100
Message-ID	<qp7LH-8qM-3@gated-at.bofh.it> (permalink)
References	<qp7LH-8qM-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The current code waits until the transmitter becomes empty,
before sending each character, and after finishing the whole string.
This seems a bit redundant.

It can be more efficient by checking the transmitter only after sending
each character.  This should be safe because the transmitter is already
empty at the first entry of serial_putc().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/tty/serial/8250/8250_early.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
index 23c322f..0b65a26 100644
--- a/drivers/tty/serial/8250/8250_early.c
+++ b/drivers/tty/serial/8250/8250_early.c
@@ -90,8 +90,8 @@ static void __init wait_for_xmitr(struct uart_port *port)
 
 static void __init serial_putc(struct uart_port *port, int c)
 {
-	wait_for_xmitr(port);
 	serial8250_early_out(port, UART_TX, c);
+	wait_for_xmitr(port);
 }
 
 static void __init early_serial8250_write(struct console *console,
@@ -101,9 +101,6 @@ static void __init early_serial8250_write(struct console *console,
 	struct uart_port *port = &device->port;
 
 	uart_console_write(port, s, count, serial_putc);
-
-	/* Wait for transmitter to become empty */
-	wait_for_xmitr(port);
 }
 
 static void __init init_port(struct earlycon_device *device)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v3 2/3] serial: 8250_early: confirm empty transmitter after sending characters Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-30 03:40 +0100

csiph-web