Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259066

Re: [PATCH] sparc64: Fix numa distance values

Show all headers | View raw

On 10/29/2015 11:50 AM, Sam Ravnborg wrote:
> Small nit.
>
>> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
>> index 01d1704..ed3dfdd 100644
>> --- a/arch/sparc/include/asm/topology_64.h
>> +++ b/arch/sparc/include/asm/topology_64.h
>> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>>   	 cpu_all_mask : \
>>   	 cpumask_of_node(pcibus_to_node(bus)))
>>
>> +extern int __node_distance(int, int);
> We have dropped using "extern" for function prototypes.
>

ok, dropped extern here.

>> +#define node_distance(a, b) __node_distance(a, b)
>
> And had this be written as:
> #define node_distance node_distance

underscores here to separate macro name from function name
seems to be clearer and would also avoid confusing
cross-referencing tools.

> int node_distance(int, int);
>
> Then there had been no need for the leadign underscores.
>
> But as I said - only nits.
>
> 	Sam
>
Thanks for the review.
Nitin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sparc64: Fix numa distance values Nitin Gupta <nitin.m.gupta@oracle.com> - 2015-10-29 01:10 +0100
  Re: [PATCH] sparc64: Fix numa distance values Sam Ravnborg <sam@ravnborg.org> - 2015-10-29 20:00 +0100
    Re: [PATCH] sparc64: Fix numa distance values Nitin Gupta <nitin.m.gupta@oracle.com> - 2015-10-29 23:50 +0100

csiph-web