Re: [PATCH v2] blktrace: re-write setting q->blk_trace

From	Jeff Moyer <jmoyer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] blktrace: re-write setting q->blk_trace
Date	2015-10-29 22:00 +0100
Message-ID	<qp2sG-567-15@gated-at.bofh.it> (permalink)
References	(2 earlier) <qoGBP-84j-5@gated-at.bofh.it> <qp0TT-4iv-9@gated-at.bofh.it> <qp1ZD-4UY-5@gated-at.bofh.it> <qp2j0-51p-7@gated-at.bofh.it> <qp2j0-51p-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Jens Axboe <axboe@kernel.dk> writes:

> On 10/30/2015 05:46 AM, Jeff Moyer wrote:
>> Jens Axboe <axboe@kernel.dk> writes:
>>
>>> On 10/30/2015 04:19 AM, Davidlohr Bueso wrote:
>>>>
>>>>> The patch itself looks ok, but it doesn't seem to apply to a recent
>>>>> kernel tree.  It appears as though it is white-space damaged.  Would you
>>>>> mind re-sending it?
>>>>
>>>> Hmm sorry about that. I thought I had based it against that day's
>>>> tip/master.
>>>> Anyway, here is v3 which is against tip/master as of
>>>> 338e29ba93639138fafb9fb5ba946fd99a512aae.
>>>
>>> Thanks, this is definitely cleaner. Your patch is still pretty
>>> mangled, though. I had to hand apply it. Please check the result:
>>
>> Heh, and here I just assumed the problem was on my end.
>>
>>> http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.4/core&id=cdea01b2bf98affb7e9c44530108a4a28535eee8
>>
>> That looks fine, except you're missing the 'R' in Reviewed-by.
>
> e-viewed. Electronically viewed by jeff?

Heh.  Well, that's not wrong!  ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] blktrace: re-write setting q->blk_trace Davidlohr Bueso <dave@stgolabs.net> - 2015-10-27 04:10 +0100
  [PATCH v2] blktrace: re-write setting q->blk_trace Davidlohr Bueso <dave@stgolabs.net> - 2015-10-27 04:20 +0100
    Re: [PATCH v2] blktrace: re-write setting q->blk_trace Jeff Moyer <jmoyer@redhat.com> - 2015-10-28 22:40 +0100
      Re: [PATCH v2] blktrace: re-write setting q->blk_trace Davidlohr Bueso <dave@stgolabs.net> - 2015-10-29 20:20 +0100
        Re: [PATCH v2] blktrace: re-write setting q->blk_trace Jeff Moyer <jmoyer@redhat.com> - 2015-10-29 20:40 +0100
        Re: [PATCH v2] blktrace: re-write setting q->blk_trace Jens Axboe <axboe@kernel.dk> - 2015-10-29 21:30 +0100
          Re: [PATCH v2] blktrace: re-write setting q->blk_trace Jens Axboe <axboe@kernel.dk> - 2015-10-29 21:50 +0100
            Re: [PATCH v2] blktrace: re-write setting q->blk_trace Jeff Moyer <jmoyer@redhat.com> - 2015-10-29 22:00 +0100
          Re: [PATCH v2] blktrace: re-write setting q->blk_trace Jeff Moyer <jmoyer@redhat.com> - 2015-10-29 21:50 +0100
          Re: [PATCH v2] blktrace: re-write setting q->blk_trace Davidlohr Bueso <dave@stgolabs.net> - 2015-10-29 22:10 +0100

csiph-web