Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258997

Re: [PATCHv2 2/3] tools: build: fix libiberty feature detection

Show all headers | View raw

On Thu, Oct 29, 2015 at 08:49:37AM +0100, Rabin Vincent wrote:
> Any CFLAGS or LDFLAGS set by the user need to be passed to the feature build
> command.  This many include for example -I or -L to point to libraries and
> include files in custom paths.
> 
> In most of the test-*.bin rules in build/feature/Makefile, we use the BUILD
> macro which always sends in CFLAGS and LDFLAGS.  The libiberty build line
> however doesn't use the BUILD macro and thus needs to send in CFLAGS and
> LDFLAGS explicitly.  Without this, when using custom CFLAGS/LDFLAGS, libiberty
> fails to be detected and the perf link fails with something like:
> 
>   LINK     perf
>  libbfd.a(bfd.o): In function `bfd_errmsg':
>  bfd.c:(.text+0x168): undefined reference to `xstrerror'
>  bbfd.a(opncls.o): In function `_bfd_new_bfd':
>  opncls.c:(.text+0xe8): undefined reference to `objalloc_create'
>  ...
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 1/3] perf: unwind: pass symbol source to libunwind Rabin Vincent <rabin.vincent@axis.com> - 2015-10-29 09:00 +0100
  [PATCHv2 3/3] perf: add helper makefile for cross compiling libs Rabin Vincent <rabin.vincent@axis.com> - 2015-10-29 09:00 +0100
    Re: [PATCHv2 3/3] perf: add helper makefile for cross compiling libs Ingo Molnar <mingo@kernel.org> - 2015-10-29 10:50 +0100
  [PATCHv2 2/3] tools: build: fix libiberty feature detection Rabin Vincent <rabin.vincent@axis.com> - 2015-10-29 09:00 +0100
    Re: [PATCHv2 2/3] tools: build: fix libiberty feature detection Jiri Olsa <jolsa@redhat.com> - 2015-10-29 21:50 +0100
    [tip:perf/core] tools build: Fix libiberty feature detection tip-bot for Rabin Vincent <tipbot@zytor.com> - 2015-10-30 10:20 +0100
  [tip:perf/core] perf unwind: Pass symbol source to libunwind tip-bot for Rabin Vincent <tipbot@zytor.com> - 2015-10-30 10:20 +0100

csiph-web