Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258035

Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops

Show all headers | View raw

Hello,

On Wed, Oct 28, 2015, at 14:32, Dan Streetman wrote:
> On Tue, Oct 27, 2015 at 12:15 PM,  <dan.streetman@canonical.com> wrote:
> > From: Dan Streetman <dan.streetman@canonical.com>
> >
> > The ipv4 and ipv6 xfrms each create a template dst_ops object, and
> > perform dst_entries_init() on the template objects.  Then each net
> > namespace has its net.xfrm.xfrm[46]_dst_ops field set to the template
> > values.  The problem with that is the dst_ops.pcpuc_entries field is
> > a percpu counter and cannot be used correctly by simply copying it to
> > another object.

How hard would it be to split of the counters from the dst_ops struct?
We could make dst_ops instances const and have normal pointers to them
and keep the dst_entries as a small array in net namespace?

Bye,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xfrm: dst_entries_init() per-net dst_ops dan.streetman@canonical.com - 2015-10-27 17:20 +0100
  Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops Dan Streetman <dan.streetman@canonical.com> - 2015-10-28 14:40 +0100
    Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-10-28 14:50 +0100
      Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops Dan Streetman <dan.streetman@canonical.com> - 2015-10-28 16:10 +0100
    Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops David Miller <davem@davemloft.net> - 2015-10-28 15:00 +0100
  [PATCHv2] xfrm: dst_entries_init() per-net dst_ops Dan Streetman <dan.streetman@canonical.com> - 2015-10-29 12:40 +0100
    Re: [PATCHv2] xfrm: dst_entries_init() per-net dst_ops kbuild test robot <lkp@intel.com> - 2015-10-29 13:00 +0100
      Re: [PATCHv2] xfrm: dst_entries_init() per-net dst_ops Dan Streetman <dan.streetman@canonical.com> - 2015-10-29 14:50 +0100
    [PATCHv3] xfrm: dst_entries_init() per-net dst_ops Dan Streetman <dan.streetman@canonical.com> - 2015-10-29 15:00 +0100

csiph-web