Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1257867

Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

From Johan Hovold <johan@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] coccinelle: misc: remove "complex return code" warnings
Date 2015-10-28 11:00 +0100
Message-ID <qovGq-VU-1@gated-at.bofh.it> (permalink)
References <qeycx-1Kc-13@gated-at.bofh.it> <qfxR8-75Z-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote:
> Should have acked this message...
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> On Wed, 30 Sep 2015, Johan Hovold wrote:
> 
> > This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch
> > to delete overly complex return code processing").
> >
> > There can be both symmetry and readability reasons for not wanting to do
> > the final function call as part of the return statement and to maintain
> > a clear separation of success and error paths.
> >
> > Since this is in no way mandated by the coding standard, let's just
> > remove this semantic patch to avoid having "clean up" patches being
> > posted over and over in response to these Coccinelle warnings.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>

Is anyone planning on picking this patch up?

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] coccinelle: misc: remove "complex return code" warnings Johan Hovold <johan@kernel.org> - 2015-10-28 11:00 +0100
  Re: [PATCH] coccinelle: misc: remove "complex return code" warnings Johan Hovold <johan@kernel.org> - 2015-10-28 11:10 +0100
  Re: [PATCH] coccinelle: misc: remove "complex return code" warnings Michal Marek <mmarek@suse.com> - 2015-10-28 11:10 +0100

csiph-web