Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257768

Re: [PATCH 4/4] Mark files generated by confdata.c

Show all headers | View raw

On Tue, Oct 27, 2015 at 10:16:11PM +0100, Michal Marek wrote:
> Dne 27.10.2015 v 16:30 Nicholas Mc Guire napsal(a):
> > scripts/kconfig/confdata.c generates a number of files - indicate the 
> > location of the generator in the file heading to ease reading the sources.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
> > This is no actual code change - compile-testing should thus do
> > checkpatch.pl will fuss about "WARNING: quoted string split across lines"
> > but it seems this is fine in this case given the initial code.
> > 
> > Compile tested with x86_64_defconfig
> > 
> > Patch is against 4.3-rc6 (localversion-next is  -next-20151022)
> > 
> >  scripts/kconfig/confdata.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> > index 0b7dc2f..6a2be59 100644
> > --- a/scripts/kconfig/confdata.c
> > +++ b/scripts/kconfig/confdata.c
> > @@ -651,7 +651,8 @@ conf_write_heading(FILE *fp, struct conf_printer *printer, void *printer_arg)
> >  
> >  	snprintf(buf, sizeof(buf),
> >  	    "\n"
> > -	    "Automatically generated file; DO NOT EDIT.\n"
> > +	    "Automatically generated by scripts/kconfig/confdata.c:"
> > +	    " DO NOT EDIT.\n"
> 
> You cannot run the C source to regenerate the file, so how about
> "generated by kconfig"?
>
Yup that makes more sense - and it would still point the reader into the
right direction - will go check the other cases as well.

thx!
hofrat 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Add generator notes to generated files Nicholas Mc Guire <hofrat@osadl.org> - 2015-10-27 17:00 +0100
  [PATCH 4/4] Mark files generated by confdata.c Nicholas Mc Guire <hofrat@osadl.org> - 2015-10-27 17:00 +0100
    Re: [PATCH 4/4] Mark files generated by confdata.c Michal Marek <mmarek@suse.com> - 2015-10-27 22:20 +0100
      Re: [PATCH 4/4] Mark files generated by confdata.c Michal Marek <mmarek@suse.com> - 2015-10-28 09:10 +0100
      Re: [PATCH 4/4] Mark files generated by confdata.c Nicholas Mc Guire <der.herr@hofr.at> - 2015-10-28 09:10 +0100
  [PATCH 2/4] utsrelease.h: Make it clear where files are generated Nicholas Mc Guire <hofrat@osadl.org> - 2015-10-27 17:00 +0100

csiph-web