Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257724

[PATCH v2] cputime: fix invalid gtime

Show all headers | View raw

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

/proc/stats shows invalid gtime when the thread is running in guest.
When vtime accounting is not enabled, we cannot get a valid delta.
The delta is calculated now - tsk->vtime_snap, but tsk->vtime_snap
is only updated when vtime accounting is enabled.

This patch makes task_gtime() just return gtime when vtime accounting
is not enabled.

The kernel config contains CONFIG_VIRT_CPU_ACCOUNTING_GEN=y and
CONFIG_NO_HZ_FULL_ALL=n and boot without nohz_full.

I ran and stop a busy loop in VM and see the gtime in host.
Dump the 43rd field which shows the gtime in every second.
 # while :; do awk '{print $3" "$43}' /proc/3955/task/4014/stat; sleep 1; done
S 4348
R 7064566
R 7064766
R 7064967
R 7065168
S 4759
S 4759

During running busy loop, it returns large value.

After applying this patch, we can see right gtime.

 # while :; do awk '{print $3" "$43}' /proc/10913/task/10956/stat; sleep 1; done
S 5338
R 5365
R 5465
R 5566
R 5666
S 5726
S 5726

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
 kernel/sched/cputime.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index 8cbc3db..f614ee9 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -786,6 +786,9 @@ cputime_t task_gtime(struct task_struct *t)
 	unsigned int seq;
 	cputime_t gtime;
 
+	if (!vtime_accounting_enabled())
+		return t->gtime;
+
 	do {
 		seq = read_seqbegin(&t->vtime_seqlock);
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] cputime: fix invalid gtime Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> - 2015-10-28 08:10 +0100
  Re: [PATCH v2] cputime: fix invalid gtime Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-28 17:20 +0100
    RE: [PATCH v2] cputime: fix invalid gtime Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> - 2015-10-29 02:20 +0100
      Re: [PATCH v2] cputime: fix invalid gtime Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-29 04:50 +0100
        RE: [PATCH v2] cputime: fix invalid gtime Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> - 2015-10-29 05:40 +0100
          Re: [PATCH v2] cputime: fix invalid gtime Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-29 13:50 +0100

csiph-web