Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257711

Re: [PATCH V3 3/5] cpufreq: ondemand: queue work for policy->cpus together

Show all headers | View raw

On 28-10-15, 07:38, Rafael J. Wysocki wrote:
> On Tuesday, October 13, 2015 01:39:03 PM Viresh Kumar wrote:
> > Currently update_sampling_rate() runs over each online CPU and
> > cancels/queues work on it. Its very inefficient for the case where a
> > single policy manages multiple CPUs, as they can be processed together.
> 
> In the case of one policy object shared between multiple CPUs, I'm
> wondering why we don't use a single delayed work function for all of them
> in the first place.  That would address the problem at the source instead
> of dealing with the symptoms.

That's what we had long back. The problem is that the timers queued
for cpufreq are deferrable and if the CPU, on which the timer is
queued, goes idle, then the governor would halt. And there can be
other CPUs in the policy->cpus group which are still running.

> > Also drop the unnecessary cancel_delayed_work_sync() as we are doing a
> > mod_delayed_work_on() in gov_queue_work(), which will take care of
> > pending works for us.
> 
> I'd prefer a separate patch for that if poss.

okay.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3 3/5] cpufreq: ondemand: queue work for policy->cpus together "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-28 07:10 +0100
  Re: [PATCH V3 3/5] cpufreq: ondemand: queue work for policy->cpus  together Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-28 07:50 +0100
    Re: [PATCH V3 3/5] cpufreq: ondemand: queue work for policy->cpus together "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-28 08:10 +0100
      Re: [PATCH V3 3/5] cpufreq: ondemand: queue work for policy->cpus  together Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-28 09:40 +0100

csiph-web