Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1257668

Re: [PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on kernel entry and exit

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on kernel entry and exit
Date 2015-10-28 06:30 +0100
Message-ID <qort8-6PV-11@gated-at.bofh.it> (permalink)
References <qoo2d-4uc-5@gated-at.bofh.it> <qoo2e-4uc-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Oct 27, 2015 at 6:39 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> x86 always calls user_enter and user_exit with interrupt disabled.
> Therefore, it is not necessary to check for exceptions, nor to
> save/restore the IRQ state, when context tracking functions are
> called by guest_enter and guest_exit.
>
> Use the previously introduced __context_tracking_entry and
> __context_tracking_exit.

x86 isn't ready for this yet.  We could do a quick-and-dirty fix with
explicit IRQs-on-and-off much protected by the static key, or we could
just wait until I finish the syscall cleanup.  I favor the latter, but
you're all welcome to do the former and I'll review it.

BTW, Frederic, I have a static key patch coming that I think you'll
like.  I'll send it tomorrow once I'm in front of a real computer.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on kernel entry and exit Paolo Bonzini <pbonzini@redhat.com> - 2015-10-28 02:50 +0100
  Re: [PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on  kernel entry and exit Andy Lutomirski <luto@amacapital.net> - 2015-10-28 06:30 +0100
    Re: [PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on  kernel entry and exit Paolo Bonzini <pbonzini@redhat.com> - 2015-10-28 16:00 +0100

csiph-web