Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1257490
| From | Brian Norris <computersforpeace@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 |
| Date | 2015-10-28 01:20 +0100 |
| Message-ID | <qomD8-3DG-3@gated-at.bofh.it> (permalink) |
| References | <qmCVI-8u2-3@gated-at.bofh.it> <qmCVI-8u2-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Oct 23, 2015 at 10:46:13AM +0530, Anup Patel wrote:
> The NAND controller on NS2 SoC is compatible with existing
> BRCM IPROC NAND driver so let's enable it in NS2 DT and
> NS2 SVK DT.
>
> This patch also fixes use of node labels in ns2-svk.dts.
>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> Reviewed-by: Ray Jui <rjui@broadcom.com>
> Reviewed-by: Scott Branden <sbranden@broadcom.com>
> ---
> arch/arm64/boot/dts/broadcom/ns2-svk.dts | 30 ++++++++++++++++++++----------
> arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 ++++++++++++++
> 2 files changed, 34 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> index e5950d5..6bb3d4d 100644
> --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> @@ -50,18 +50,28 @@
> device_type = "memory";
> reg = <0x000000000 0x80000000 0x00000000 0x40000000>;
> };
> +};
>
> - soc: soc {
> - i2c0: i2c@66080000 {
> - status = "ok";
> - };
> +&i2c0 {
> + status = "ok";
> +};
>
> - i2c1: i2c@660b0000 {
> - status = "ok";
> - };
> +&i2c1 {
> + status = "ok";
> +};
> +
> +&uart3 {
> + status = "ok";
> +};
>
> - uart3: serial@66130000 {
> - status = "ok";
> - };
> +&nand {
> + nandcs@0 {
> + compatible = "brcm,nandcs";
> + reg = <0>;
> + nand-ecc-mode = "hw";
> + nand-ecc-strength = <8>;
> + nand-ecc-step-size = <512>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> };
> };
> diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> index f603277..9610822 100644
> --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> @@ -212,5 +212,19 @@
> compatible = "brcm,iproc-rng200";
> reg = <0x66220000 0x28>;
> };
> +
> + nand: nand@66460000 {
> + compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1";
Technically, the binding says you should also have "brcm,brcmnand" as a
last resort. Otherwise (for the NAND parts):
Reviewed-by: Brian Norris <computersforpeace@gmail.com>
> + reg = <0x66460000 0x600>,
> + <0x67015408 0x600>,
> + <0x66460f00 0x20>;
> + reg-names = "nand", "iproc-idm", "iproc-ext";
> + interrupts = <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + brcm,nand-has-wp;
> + };
> };
> };
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Anup Patel <anup.patel@broadcom.com> - 2015-10-23 07:20 +0200
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Brian Norris <computersforpeace@gmail.com> - 2015-10-28 01:20 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Ray Jui <rjui@broadcom.com> - 2015-10-28 01:30 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Brian Norris <computersforpeace@gmail.com> - 2015-10-28 01:40 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Ray Jui <rjui@broadcom.com> - 2015-10-28 01:50 +0100
RE: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Anup Patel <anup.patel@broadcom.com> - 2015-10-28 10:10 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Ray Jui <rjui@broadcom.com> - 2015-10-28 17:10 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Florian Fainelli <f.fainelli@gmail.com> - 2015-10-28 20:00 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Brian Norris <computersforpeace@gmail.com> - 2015-10-30 19:50 +0100
Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Ray Jui <rjui@broadcom.com> - 2015-10-30 20:00 +0100
csiph-web