Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1257447

Re: 4.3-rc7: kmemleak BUG: Redzone overwritten

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: 4.3-rc7: kmemleak BUG: Redzone overwritten
Date 2015-10-27 23:50 +0100
Message-ID <qole2-2DR-25@gated-at.bofh.it> (permalink)
References <qoePg-70a-7@gated-at.bofh.it> <qokL0-2rO-25@gated-at.bofh.it> <qol4m-2Aj-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Oct 28, 2015 at 7:39 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> I don't think it should be fixed like this.

Right. The seqfile code really doesn't care about the terminating NUL
character, and just cares that the buffer isn't overwritten past the
end. But other users of the hex dump code may need the final NUL for
the overflow case, and would want the text itself to be truncated
rather than dropping the NUL.

So I'm certainly fine with your approach too. Aaro, can you check
Andy's version instead of mine?

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

4.3-rc7: kmemleak BUG: Redzone overwritten Aaro Koskinen <aaro.koskinen@nokia.com> - 2015-10-27 17:00 +0100
  Re: 4.3-rc7: kmemleak BUG: Redzone overwritten Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-27 17:00 +0100
    Re: 4.3-rc7: kmemleak BUG: Redzone overwritten Aaro Koskinen <aaro.koskinen@nokia.com> - 2015-10-27 17:20 +0100
  Re: 4.3-rc7: kmemleak BUG: Redzone overwritten Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-27 23:20 +0100
    Re: 4.3-rc7: kmemleak BUG: Redzone overwritten Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-27 23:40 +0100
      Re: 4.3-rc7: kmemleak BUG: Redzone overwritten Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-27 23:50 +0100

csiph-web