Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257273

Re: block: re-add discard_granularity and alignment checks

Show all headers | View raw

On Thu, Oct 22, 2015 at 10:03 AM, Mike Snitzer <snitzer@redhat.com> wrote:
> On Thu, Oct 22 2015 at 12:59pm -0400,
> Ming Lin <mlin@kernel.org> wrote:
>
>> From: Ming Lin <ming.l@ssi.samsung.com>
>>
>> In commit b49a087("block: remove split code in
>> blkdev_issue_{discard,write_same}"), discard_granularity and alignment
>> checks were removed. Ideally, with bio late splitting, the upper layers
>> shouldn't need to depend on device's limits.
>>
>> Christoph reported a discard regression on the HGST Ultrastar SN100 NVMe
>> device when mkfs.xfs. We have not found the root cause yet.
>>
>> This patch re-adds discard_granularity and alignment checks by reverting
>> the related changes in commit b49a087. The good thing is now we can
>> remove the 2G discard size cap and just use UINT_MAX to avoid bi_size
>> overflow.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Tested-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>
>
> Reviewed-by: Mike Snitzer <snitzer@redhat.com>

Hi Jens,

Would you please take this one?

>
> Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block: re-add discard_granularity and alignment checks Ming Lin <mlin@kernel.org> - 2015-10-22 19:10 +0200
  Re: block: re-add discard_granularity and alignment checks Mike Snitzer <snitzer@redhat.com> - 2015-10-22 19:10 +0200
    Re: block: re-add discard_granularity and alignment checks Ming Lin <mlin@kernel.org> - 2015-10-27 22:30 +0100
      Re: block: re-add discard_granularity and alignment checks Jens Axboe <axboe@kernel.dk> - 2015-10-28 01:20 +0100

csiph-web