Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257266

Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

Show all headers | View raw

On Fri, 23 Oct, at 11:48:17AM, Ard Biesheuvel wrote:
> From: Taku Izumi <izumi.taku@jp.fujitsu.com>
> 
> Commit 0f96a99dab36 ("efi: Add "efi_fake_mem" boot option")
> introduces the following warning message:
> 
>   drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer
>   from integer of different size [-Wint-to-pointer-cast]
> 
> new_memmap_phy was defined as a u64 value and cast to void*, causing
> a int-to-pointer-cast warning on x86 32-bit builds.
> However, since the void* type is inappropriate for a physical
> address, the definition of struct efi_memory_map::phys_map has been
> changed to phys_addr_t in the previous patch, and so the cast can be
> dropped entirely.
> 
> This patch also changes the type of the "new_memmap_phy" variable
> from "u64" to "phys_addr_t" to align with the types of
> memblock_alloc() and struct efi_memory_map::phys_map.
> 
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
> [ard.biesheuvel: removed void* cast, updated commit log]
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  drivers/firmware/efi/fake_mem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Taku Izumi <izumi.taku@jp.fujitsu.com> - 2015-10-23 02:50 +0200
  Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-10-23 10:40 +0200
    Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit  builds Ingo Molnar <mingo@kernel.org> - 2015-10-23 11:00 +0200
      [PATCH 1/2] efi: use correct type for struct efi_memory_map::phys_map Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-10-23 11:50 +0200
        [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-10-23 11:50 +0200
          Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86  32-bit builds Ingo Molnar <mingo@kernel.org> - 2015-10-23 12:30 +0200
            Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86  32-bit builds Ingo Molnar <mingo@kernel.org> - 2015-10-23 12:40 +0200
              Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86  32-bit builds Ingo Molnar <mingo@kernel.org> - 2015-10-23 12:40 +0200
                Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86  32-bit builds Matt Fleming <matt@codeblueprint.co.uk> - 2015-10-27 22:20 +0100
                Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86  32-bit builds Ingo Molnar <mingo@kernel.org> - 2015-10-28 12:40 +0100
          Re: [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86  32-bit builds Matt Fleming <matt@codeblueprint.co.uk> - 2015-10-27 22:20 +0100
          [tip:core/efi] efi:   Fix warning of int-to-pointer-cast on x86 32-bit builds tip-bot for Taku Izumi <tipbot@zytor.com> - 2015-10-28 22:00 +0100
        Re: [PATCH 1/2] efi: use correct type for struct  efi_memory_map::phys_map Matt Fleming <matt@codeblueprint.co.uk> - 2015-10-27 22:10 +0100
        [tip:core/efi] efi: Use correct type for struct efi_memory_map::  phys_map tip-bot for Ard Biesheuvel <tipbot@zytor.com> - 2015-10-28 22:00 +0100
    Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit  builds Matt Fleming <matt@codeblueprint.co.uk> - 2015-10-26 22:10 +0100
      Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-10-27 03:40 +0100
        Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit  builds Matt Fleming <matt@codeblueprint.co.uk> - 2015-10-27 22:10 +0100
  Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit  builds Ingo Molnar <mingo@kernel.org> - 2015-10-23 10:50 +0200

csiph-web