Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257078

Re: [PATCH] ixgbe: Wait for 1ms, not 1us, after RST

Show all headers | View raw

Hi Dan,

On 10/26/2015 08:16 PM, dan.streetman@canonical.com wrote:
> From: Dan Streetman <dan.streetman@canonical.com>
> 
> The driver currently waits 1us after issuing a RST, but the spec
> requires it to wait 1ms.
> 
> Signed-off-by: Dan Streetman <dan.streetman@canonical.com>
> Signed-off-by: Dan Streetman <ddstreet@ieee.org>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
> index 4e75843..147bc65 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
> @@ -113,7 +113,12 @@ mac_reset_top:
>  
>  	/* Poll for reset bit to self-clear indicating reset is complete */
>  	for (i = 0; i < 10; i++) {
> -		udelay(1);
> +		/* sec 8.2.4.1.1 :
> +		 * programmers must wait approximately 1 ms after setting before
> +		 * attempting to check if the bit has cleared or to access (read
> +		 * or write) any other device register.
> +		 */
> +		mdelay(1);

Since ixgbe_reset_hw_x540() goes on to msleep(100) immediately after this
busy-wait loop, this should instead be:

		msleep(1);

Regards,
Peter Hurley


>  		ctrl = IXGBE_READ_REG(hw, IXGBE_CTRL);
>  		if (!(ctrl & IXGBE_CTRL_RST_MASK))
>  			break;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ixgbe: Wait for 1ms, not 1us, after RST dan.streetman@canonical.com - 2015-10-27 01:20 +0100
  RE: [PATCH] ixgbe: Wait for 1ms, not 1us, after RST "Skidmore, Donald C" <donald.c.skidmore@intel.com> - 2015-10-27 18:10 +0100
    Re: [PATCH] ixgbe: Wait for 1ms, not 1us, after RST Dan Streetman <dan.streetman@canonical.com> - 2015-10-27 19:00 +0100
  Re: [PATCH] ixgbe: Wait for 1ms, not 1us, after RST Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 19:00 +0100
    [PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST Dan Streetman <dan.streetman@canonical.com> - 2015-10-27 19:30 +0100

csiph-web