Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257073

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

Show all headers | View raw

Hi Boris,

On Tue, Oct 27, 2015 at 08:42:00AM +0100, Boris Brezillon wrote:
> On Mon, 26 Oct 2015 19:31:06 -0700
> Brian Norris <computersforpeace@gmail.com> wrote:
> 
> > It seems more logical to use a device node directly associated with the
> > MTD master device (i.e., mtd->dev.of_node field) rather than requiring
> > auxiliary partition parser information to be passed in by the driver in
> > a separate struct.
> > 
> > This patch supports the mtd->dev.of_node field, deprecates the parser
> > data 'of_node' field, and begins using the new convention for nand_base.
> > Other NAND driver conversions may now follow.
> > 
> > Additional side benefit to assigning mtd->dev.of_node rather than using
> > parser data: the driver core will automatically create a device -> node
> > symlink for us.
> 
> I like the idea, but how about pushing the solution even further and
> killing the ->flash_node field which AFAICT is rendered useless by
> your patch?

I suppose we could do that. I do think there's something to be said for
layering, though. Historically, we haven't done a very good job of
layering in MTD, so low-level drivers often have to poke around in the
MTD structures, even if they really should only have to know a few
things about their helper subsystem/library, like NAND or SPI NOR. So
with that in mind, I think the ->flash_node serves some purpose --
drivers can just initialize struct nand_chip/spi_nor and be assured that
the NAND/SPI-NOR subsystems will take care of things.

Now, I don't think there's much reason to suspect that we'd have a more
complex mapping than 1:1 between struct mtd_info and struct nand_chip or
struct spi_nor, so maybe we don't actually need duplicate storage
(mtd.dev.of_node and {spi_nor,nand_chip}.flash_node), and the layering
is just have these APIs:

	nand_set_flash_node()
	spi_nor_set_flash_node()

which just call mtd_set_of_node()?

Speaking of layering: why do we have NAND drivers initializing mtd->priv
for us, yet nand_base just assumes that it points to a struct nand_chip?
And why isn't struct mtd_info just embedded in struct nand_chip? Are
there ever cases we want more than one (master) MTD per nand_chip? Or
vice versa?

Thanks for the review,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] mtd: migrate 'of_node' handling to core, not in mtd_part_parser_data Brian Norris <computersforpeace@gmail.com> - 2015-10-27 03:40 +0100
  [PATCH 3/5] mtd: spi-nor: drop unnecessary partition parser data Brian Norris <computersforpeace@gmail.com> - 2015-10-27 03:40 +0100
  [PATCH 4/5] mtd: drop unnecessary partition parser data Brian Norris <computersforpeace@gmail.com> - 2015-10-27 03:40 +0100
  [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Brian Norris <computersforpeace@gmail.com> - 2015-10-27 03:40 +0100
    Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-27 08:50 +0100
      Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Brian Norris <computersforpeace@gmail.com> - 2015-10-27 19:00 +0100
        Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Brian Norris <computersforpeace@gmail.com> - 2015-10-28 02:10 +0100
          Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-28 09:10 +0100
        Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-28 09:00 +0100
          Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Marek Vasut <marex@denx.de> - 2015-10-28 17:20 +0100
            Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-28 17:40 +0100
              Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Brian Norris <computersforpeace@gmail.com> - 2015-10-28 18:20 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-28 22:10 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Marek Vasut <marex@denx.de> - 2015-10-28 23:50 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-29 07:40 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-29 08:30 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Marek Vasut <marex@denx.de> - 2015-10-29 18:30 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from  master device node Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-29 18:40 +0100
                Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-29 21:40 +0100
              Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Marek Vasut <marex@denx.de> - 2015-10-28 21:40 +0100
  [PATCH 5/5] mtd: drop 'of_node' partition parser data Brian Norris <computersforpeace@gmail.com> - 2015-10-27 03:40 +0100

csiph-web