Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256899

Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put

Show all headers | View raw

On Sat, Oct 24, 2015 at 4:42 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
>
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Patch applied with Ludovic's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 9/9] pinctrl: at91: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-10-26 11:00 +0100
  Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put Linus Walleij <linus.walleij@linaro.org> - 2015-10-27 17:20 +0100

csiph-web