Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256892

Re: [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller

Show all headers | View raw

On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:

> HW and driver support the GPIO as interrupt-controller. Document that in
> the DT binding.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Patch subject augmented and applied.

> +- interrupt-controller : Marks the device node as an interrupt controller.
> +- #interrupt-cells     : Should be 2.  The first cell is the GPIO number.
> +                         The second cell bits[3:0] is used to specify trigger type and level flags:
> +                             1 = low-to-high edge triggered.
> +                             2 = high-to-low edge triggered.
> +                             4 = active high level-sensitive.
> +                             8 = active low level-sensitive.

If these can be or:ed together, e.g 3 = both edges, that needs to be
documented. If they can't the current patch is fine I guess.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller Linus Walleij <linus.walleij@linaro.org> - 2015-10-27 17:10 +0100

csiph-web