Re: [PATCH] arm: perf: Add event descriptions

From	Christopher Covington <cov@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm: perf: Add event descriptions
Date	2015-10-27 16:50 +0100
Message-ID	<qoeFA-6WP-21@gated-at.bofh.it> (permalink)
References	(1 earlier) <q1M3E-2Xd-5@gated-at.bofh.it> <q1Mdk-38r-13@gated-at.bofh.it> <q1MGl-3Vq-11@gated-at.bofh.it> <qciYj-1MZ-25@gated-at.bofh.it> <qgV50-3kz-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/07/2015 07:20 AM, Will Deacon wrote:
> Hi again, Drew,
> 
> On Thu, Sep 24, 2015 at 06:52:57PM +0100, Will Deacon wrote:
>> On Mon, Aug 17, 2015 at 10:40:36PM +0100, Drew Richardson wrote:
>>> So my suggestion to solve the problem is that the kernel can have the
>>> list of events as proposed in the patch.
>>
>> Sorry, but I just don't buy this argument. Your problem is that the user
>> needs to be running an up-to-date perf tool, but with your proposed
>> solution, you're asking them to update the *kernel* instead, which is
>> (unfortunately) one of the hardest pieces of software to upgrade on a
>> typical ARM platform.
> 
> I've spent some time thinking about this and, actually, it makes sense
> to do this for the architected events. These event numbers are guaranteed
> to be portable between CPUs, so if we expose those through sysfs then
> we don't have this dependency on updating the kernel for newer cores
> (well, once the initial period without your patch has expired). It's the
> noon-portable, micro-architectural events that I object to.
> 
> So how about you roll a new version of this patch just exposing the
> architected events and making use of the macros in perf_event.h to make
> it a bit tidier (PMU_EVENT_ATTR, PMU_EVENT_ATTR_STRING etc)?
> 
> Be aware that there's a fair amount of arm64 perf patches queue for 4.4,
> since we're moving over to the code in drivers/perf/. Hopefully these
> will appear on the arm64 for-next/core branch shortly.

Have you considered using OF/ACPI to describe this aspect of the hardware?

Thanks,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] arm: perf: Add event descriptions Christopher Covington <cov@codeaurora.org> - 2015-10-27 16:50 +0100
  Re: [PATCH] arm: perf: Add event descriptions Mark Rutland <mark.rutland@arm.com> - 2015-10-27 17:10 +0100
    Re: [PATCH] arm: perf: Add event descriptions Christopher Covington <cov@codeaurora.org> - 2015-10-28 15:20 +0100
      Re: [PATCH] arm: perf: Add event descriptions Mark Rutland <mark.rutland@arm.com> - 2015-10-28 15:30 +0100

csiph-web