Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1256760

Re: [PATCH v3] serial: support 16-bit register interface for console

From Peter Hurley <peter@hurleysoftware.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3] serial: support 16-bit register interface for console
Date 2015-10-27 15:00 +0100
Message-ID <qocX8-5RG-15@gated-at.bofh.it> (permalink)
References <qnHqh-3zS-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Masahiro,

On 10/26/2015 12:11 AM, Masahiro Yamada wrote:
> Currently, 8-bit (MMIO) and 32-bit (MMIO32) register interfaces are
> supported for the 8250 console, but the 16-bit (MMIO16) is not.
> The 8250 UART device on my board is connected to a 16-bit bus
> and my main motivation is to use earlycon with it.
> (Refer to arch/arm/boot/dts/uniphier-support-card.dtsi)

As I noted in reviewing v2, the patch hunk below does not apply.
You must rebase your changes on top of Greg's tty-next tree.

Regards,
Peter Hurley

> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 603d2cc..325acce 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1819,8 +1819,8 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
>   *	@options: ptr for <options> field; NULL if not present (out)
>   *
>   *	Decodes earlycon kernel command line parameters of the form
> - *	   earlycon=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> - *	   console=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> + *	   earlycon=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> + *	   console=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
>   *
>   *	The optional form
>   *	   earlycon=<name>,0x<addr>,<options>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] serial: support 16-bit register interface for console Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-26 05:20 +0100
  Re: [PATCH v3] serial: support 16-bit register interface for console Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 15:00 +0100
    Re: [PATCH v3] serial: support 16-bit register interface for console Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-28 04:30 +0100

csiph-web