Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256739

Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Show all headers | View raw

Stephen Hemminger <stephen@networkplumber.org> writes:

>> +	.get_settings		= nb8800_get_settings,
>> +	.set_settings		= nb8800_set_settings,
>> +	.nway_reset		= nb8800_nway_reset,
>> +	.get_link		= ethtool_op_get_link,
>> +};
>> +
>
> Since you are implementing ethtool please add a driver
> info function.

I don't know what I'd set there that the fallback code doesn't.

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller Mans Rullgard <mans@mansr.com> - 2015-10-26 22:40 +0100
  [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller Mans Rullgard <mans@mansr.com> - 2015-10-26 22:40 +0100
    Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800  Ethernet controller Stephen Hemminger <stephen@networkplumber.org> - 2015-10-27 07:10 +0100
      Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller Måns Rullgård <mans@mansr.com> - 2015-10-27 13:50 +0100
  Re: [PATCH v3 1/2] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller Måns Rullgård <mans@mansr.com> - 2015-10-26 22:50 +0100

csiph-web