Re: [PATCH] audit: removing unused variable

From	Paul Moore <paul@paul-moore.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] audit: removing unused variable
Date	2015-10-29 15:10 +0100
Message-ID	<qoW3U-1al-9@gated-at.bofh.it> (permalink)
References	<qnH6W-3es-15@gated-at.bofh.it> <qoqno-69O-7@gated-at.bofh.it> <qoFFM-7u4-11@gated-at.bofh.it> <qoHex-5t-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 28, 2015 at 6:12 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote:
>> On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
>> > variavle rc in not required as it is just used for unchanged for return,
>> > and return is always 0 in the function.
> []
>> Thanks, applied with some spelling corrections to the description.
>
> As the return value is never actually tested,
> it seems better to make it a void function,

Agreed, I did just that yesterday.

 * https://www.redhat.com/archives/linux-audit/2015-October/msg00125.html

-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] audit: removing unused variable Saurabh Sengar <saurabh.truth@gmail.com> - 2015-10-28 05:20 +0100
  Re: [PATCH] audit: removing unused variable Paul Moore <paul@paul-moore.com> - 2015-10-28 21:40 +0100
    Re: [PATCH] audit: removing unused variable Joe Perches <joe@perches.com> - 2015-10-28 23:20 +0100
      Re: [PATCH] audit: removing unused variable Paul Moore <paul@paul-moore.com> - 2015-10-29 15:10 +0100

csiph-web