Re: [RFC v2 PATCH 07/14] irq: add a new generic IPI reservation code to irq core

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Qais Yousef <qais.yousef@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 PATCH 07/14] irq: add a new generic IPI reservation code to irq core
Date	Thu, 29 Oct 2015 11:50:02 +0100
Message-ID	<qoSWm-7uW-9@gated-at.bofh.it> (permalink)
References	<qj4Qx-3vO-3@gated-at.bofh.it> <qj4QA-3vO-39@gated-at.bofh.it> <qj7Y5-819-3@gated-at.bofh.it> <qj8Ua-Wq-5@gated-at.bofh.it> <qoB98-4v0-11@gated-at.bofh.it>
X-Original-To	Thomas Gleixner <tglx@linutronix.de>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding	7bit
X-Originating-IP	[192.168.154.94]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-kernel@vger.kernel.org>, <jason@lakedaemon.net>, <marc.zyngier@arm.com>, <jiang.liu@linux.intel.com>, <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
X-Original-Date	Thu, 29 Oct 2015 10:39:44 +0000
X-Original-Message-ID	<5631F770.3040702@imgtec.com>
X-Original-References	<1444731382-19313-1-git-send-email-qais.yousef@imgtec.com> <1444731382-19313-8-git-send-email-qais.yousef@imgtec.com> <alpine.DEB.2.11.1510131531290.25029@nanos> <561D1779.7060307@imgtec.com> <5630EDC2.10505@imgtec.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1258717

Show key headers only | View raw

On 10/28/2015 03:46 PM, Qais Yousef wrote:
> Hi Thomas,
>
> On 10/13/2015 03:38 PM, Qais Yousef wrote:
>> On 10/13/2015 02:37 PM, Thomas Gleixner wrote:
>>> On Tue, 13 Oct 2015, Qais Yousef wrote:
>>>
>>>> +    if (domain == NULL)
>>>> +        domain = irq_default_domain; /* need a separate 
>>>> ipi_default_domain? */
>>> No tail comments please.
>>>
>>> We should neither use irq_default_domain nor have an
>>> ipi_default_domain.
>>
>> OK though I understood that you were OK with using the 
>> irq_default_domain.
>>
>> This means that arch code must parse the DT for an IPI domain. I 
>> think I've seen arch code using the root FDT to search for a specific 
>> node. I'll try to do something similar to search for an IPI domain.
>
> I'm having an issue here. I made the arch code look for an IPI domain 
> but we have some platforms on MIPS that don't support device tree. I 
> can't find how I can go away with that without using irq_default_domain.
>
> Also irq_default_domain is understandably only visible within 
> irqdomain code, so I can't make the arch code fallback to passing 
> irq_default_domain if the platform doesn't support DT.
>
> Are you OK with keeping this in irq_reserve_ipi()? Alternatively I 
> could modify irq_find_host(), which I'm using to find the IPI domain, 
> return irq_default_domain() if the passed node is NULL.
>
> Or maybe there's a better option I couldn't think of?

I think I can fix this in the GIC driver by using my own 
irq_domain->ops->match() function to ignore when of_node is NULL to cope 
with platforms without DT.

Sorry for the noise.

Thanks,
Qais
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 PATCH 07/14] irq: add a new generic IPI reservation code  to irq core Qais Yousef <qais.yousef@imgtec.com> - 2015-10-28 16:50 +0100
  Re: [RFC v2 PATCH 07/14] irq: add a new generic IPI reservation code  to irq core Qais Yousef <qais.yousef@imgtec.com> - 2015-10-29 11:50 +0100

csiph-web