Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed memory

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed memory
Date	2015-10-29 11:50 +0100
Message-ID	<qoSWm-7uW-21@gated-at.bofh.it> (permalink)
References	<qmuOu-537-7@gated-at.bofh.it> <qmF7b-351-5@gated-at.bofh.it> <qo9FU-422-21@gated-at.bofh.it> <qoOJ3-4Yh-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Thu, Oct 29, 2015 at 07:12:01AM +0100, Marion & Christophe JAILLET wrote:
> 
> 
> Le 27/10/2015 11:27, Jarkko Sakkinen a écrit :
> >On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote:
> >>On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote:
> >>>Reference to the 'np' node is dropped before dereferencing the 'sizep' and
> >>>'basep' pointers, which could by then point to junk if the node has been
> >>>freed.
> >>>
> >>>Refactor code to call 'of_node_pup' later.
> >>>
> >>>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >>LGTM.
> >Is there anyone able to provide Tested-by for this?
> >
> >Christophe, were you able to reproduce the crash (insmod/rmmod couple
> >of times maybe?) and validate that it was gone after fixing the bug?
> 
> Hi,
> no, I never triggered the bug.
> This is just something noticed while looking at potential issues related to
> incorrect use of 'of_node_pup'.
> I only compile tested the patch.

The fix is so obvious that I see no reason not to include it. Thanks for
the good work.

> Best regards,
> CJ

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] TPM: Avoid reference to potentially freed memory Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2015-10-22 22:40 +0200
  Re: [PATCH] TPM: Avoid reference to potentially freed memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-10-23 09:40 +0200
    Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed  memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-10-27 11:30 +0100
      Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed  memory Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2015-10-29 07:20 +0100
        Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed  memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-10-29 11:50 +0100
          Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed  memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-10-30 12:40 +0100

csiph-web