Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1258696

[tip:perf/core] perf symbols: Fix type error when reading a build-id

From tip-bot for Dima Kogan <tipbot@zytor.com>
Newsgroups linux.kernel
Subject [tip:perf/core] perf symbols: Fix type error when reading a build-id
Date 2015-10-29 10:50 +0100
Message-ID <qoS0i-6Ul-33@gated-at.bofh.it> (permalink)
References <q6h8R-7Zt-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Commit-ID:  f2f3096888569ff1fc15fa0187a39eef3a24b28e
Gitweb:     http://git.kernel.org/tip/f2f3096888569ff1fc15fa0187a39eef3a24b28e
Author:     Dima Kogan <dima@secretsauce.net>
AuthorDate: Mon, 7 Sep 2015 17:30:28 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 28 Oct 2015 10:02:00 -0300

perf symbols: Fix type error when reading a build-id

This was benign, but wrong. The build-id should live in a char[], not a char*[]

Signed-off-by: Dima Kogan <dima@secretsauce.net>
Link: http://lkml.kernel.org/r/87si6pfwz4.fsf@secretsauce.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/symbol-minimal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c
index fd8477c..4890633 100644
--- a/tools/perf/util/symbol-minimal.c
+++ b/tools/perf/util/symbol-minimal.c
@@ -337,7 +337,7 @@ int dso__load_sym(struct dso *dso, struct map *map __maybe_unused,
 		  symbol_filter_t filter __maybe_unused,
 		  int kmodule __maybe_unused)
 {
-	unsigned char *build_id[BUILD_ID_SIZE];
+	unsigned char build_id[BUILD_ID_SIZE];
 	int ret;
 
 	ret = fd__is_64_bit(ss->fd);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[tip:perf/core] perf symbols:   Fix type error when reading a build-id tip-bot for Dima Kogan <tipbot@zytor.com> - 2015-10-29 10:50 +0100

csiph-web