Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1258545

Re: [PATCH cgroup/for-4.4] cgroup: fix race condition around termination check in css_task_iter_next()

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH cgroup/for-4.4] cgroup: fix race condition around termination check in css_task_iter_next()
Date 2015-10-29 04:10 +0100
Message-ID <qoLLb-34N-1@gated-at.bofh.it> (permalink)
References <qo878-30x-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Oct 27, 2015 at 05:45:04PM +0900, Tejun Heo wrote:
> css_task_iter_next() checked @it->cur_task before grabbing
> css_set_lock and assumed that the result won't change afterwards;
> however, tasks could leave the cgroup being iterated terminating the
> iterator before css_task_lock is acquired.  If this happens,
> css_task_iter_next() tries to calculate the current task from NULL
> cg_list pointer leading to the following oops.

Applied to cgroup/for-4.4.  Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH cgroup/for-4.4] cgroup: fix race condition around termination  check in css_task_iter_next() Tejun Heo <tj@kernel.org> - 2015-10-27 09:50 +0100
  Re: [PATCH cgroup/for-4.4] cgroup: fix race condition around  termination check in css_task_iter_next() Zefan Li <lizefan@huawei.com> - 2015-10-29 03:00 +0100
  Re: [PATCH cgroup/for-4.4] cgroup: fix race condition around  termination check in css_task_iter_next() Tejun Heo <tj@kernel.org> - 2015-10-29 04:10 +0100

csiph-web